Minor text edits on multiple pages #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 28, 2020 17:43
Besides minor editing and reformatting, I suggest removing the info indicating when the content was created since it doesn't bring much value to numpy.org users.
Proofreading before the deployment.
Proofreading before the deployment.
Proofreading before the deployment.
Proofreading before the deployment.
Proofreading before the deployment.
Proofreading before the deployment.
Proofreading before the deployment.
rgommers
reviewed
Mar 28, 2020
There was a problem hiding this comment.
Thanks @InessaPawson, very useful fixes.
I caught some more issues with the videos and tutorials listed, so I'll push a follow-up commit here for you to review.
|
|
||
| *** | ||
|
|
||
| ## NumPy Talks | ||
|
|
||
| * [The Future of NumPy Indexing](https://www.youtube.com/watch?v=o0EacbIbf58) by Jaime Fernández (2016) |
There was a problem hiding this comment.
The style changes are an improvement, but I'd like to keep the years because that gives relevant context. For talks about the state of NumPy or future plans, it matters when the talk was given.
There was a problem hiding this comment.
I see your point. I was going back and forth on whether to include the years for the talks.
Plus a couple of trivial formatting things
|
I'll merge it so it's in, we can push a follow up commit if needed. Thanks @InessaPawson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proofreading the website content before the deployment.