Skip to content

Broken links on new site #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjnath opened this issue May 17, 2020 · 7 comments · Fixed by #243
Closed

Broken links on new site #232

bjnath opened this issue May 17, 2020 · 7 comments · Fixed by #243

Comments

@bjnath
Copy link
Contributor

bjnath commented May 17, 2020

A link checker run on the new site found these 8 broken links:

1  case-studies/cricket-analytics/  Image credit for Cricket Pose Estimator  (12029)
2  community/                       'contributors' in first line (404)
3  /                                CuPy logo in Ecosystem->Array Libraries (404)
4  /                                xtensor link in Ecosystem->Array Libraries (empty href)
5  /team                            stylesheet link to /static/css/styles.css (404)
6  /learn                           'SciPy Lectures' (404)
7  /learn                           'NumPy User Guide' (404)
8  /contribute                      'User Guide' under "Developing educational materials" heading (404)

In addition the hreflang="nl" link tag in the header picks up a number of missing pages.

(Strictly speaking, this should be 9 separate issues. I'll be happy to resubmit the issues that way if we prefer.)

@rgommers
Copy link
Member

Thanks @bjnath! Good idea to run a link checker, we should do that in CI at some point.

One issue is definitely preferred over 9 separate ones here, since that's less noisy and easy to fix in one go.

@bjnath
Copy link
Contributor Author

bjnath commented May 18, 2020

One issue is definitely preferred

In my old life each would have a different owner based on who'd created the page. This is a nice change.

@bjnath
Copy link
Contributor Author

bjnath commented May 19, 2020

I will try to find where the links should go and PR these before launch.

@rgommers
Copy link
Member

In my old life each would have a different owner based on who'd created the page. This is a nice change.

If we'd be that formal, not many people would want to contribute I think. We tend to operate on trust a bit more:)

@bjnath
Copy link
Contributor Author

bjnath commented May 19, 2020

Actually, while you're here...I'm fixing these links, and have gotten to:

* [NumPy User Guide](https://numpy.org/devdocs/user/index.html)

on the /learn page. I can't figure out what I should change this to. https://numpy.org/devdocs?

@bjnath
Copy link
Contributor Author

bjnath commented May 19, 2020

And in fact I have almost the same problem with the last broken link, on the /contribute page:

NumPy's [User Guide](https://numpy.org/devdocs/user) can use a lot of help -

Somebody with a mean streak might say "even the NumPy team can't find the NumPy user guide," but I'd never be so mean.

@rgommers
Copy link
Member

I can't figure out what I should change this to. https://numpy.org/devdocs?

yes indeed

bjnath added a commit to bjnath/numpy.org that referenced this issue May 19, 2020
Fixed 7 of 8 broken links in issue numpy#232.

The remaining link is a photo credit to a site that no longer exists.
I tried to find an alternate or updated source for the photo, but
could find no references to the site and could not find the photo
in Google images. I left the link, since we didn't break it.
On that page fixed 'credit' to be consistenly lowercase and to be
singular in the case of a single image.

closes #numpygh-232
@bjnath bjnath mentioned this issue May 19, 2020
rgommers pushed a commit to bjnath/numpy.org that referenced this issue May 20, 2020
Fixed 7 of 8 broken links in issue numpy#232.

The remaining link is a photo credit to a site that no longer exists.
I tried to find an alternate or updated source for the photo, but
could find no references to the site and could not find the photo
in Google images. I left the link, since we didn't break it.
On that page fixed 'credit' to be consistenly lowercase and to be
singular in the case of a single image.

closes #numpygh-232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants