-
-
Notifications
You must be signed in to change notification settings - Fork 119
Broken links on new site #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @bjnath! Good idea to run a link checker, we should do that in CI at some point. One issue is definitely preferred over 9 separate ones here, since that's less noisy and easy to fix in one go. |
In my old life each would have a different owner based on who'd created the page. This is a nice change. |
I will try to find where the links should go and PR these before launch. |
If we'd be that formal, not many people would want to contribute I think. We tend to operate on trust a bit more:) |
Actually, while you're here...I'm fixing these links, and have gotten to:
on the /learn page. I can't figure out what I should change this to. |
And in fact I have almost the same problem with the last broken link, on the /contribute page:
Somebody with a mean streak might say "even the NumPy team can't find the NumPy user guide," but I'd never be so mean. |
yes indeed |
Fixed 7 of 8 broken links in issue numpy#232. The remaining link is a photo credit to a site that no longer exists. I tried to find an alternate or updated source for the photo, but could find no references to the site and could not find the photo in Google images. I left the link, since we didn't break it. On that page fixed 'credit' to be consistenly lowercase and to be singular in the case of a single image. closes #numpygh-232
Fixed 7 of 8 broken links in issue numpy#232. The remaining link is a photo credit to a site that no longer exists. I tried to find an alternate or updated source for the photo, but could find no references to the site and could not find the photo in Google images. I left the link, since we didn't break it. On that page fixed 'credit' to be consistenly lowercase and to be singular in the case of a single image. closes #numpygh-232
A link checker run on the new site found these 8 broken links:
In addition the
hreflang="nl"
link
tag in the header picks up a number of missing pages.(Strictly speaking, this should be 9 separate issues. I'll be happy to resubmit the issues that way if we prefer.)
The text was updated successfully, but these errors were encountered: