-
-
Notifications
You must be signed in to change notification settings - Fork 119
README should specify *extended* Hugo #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's right, good catch. You're not the first one to run into that @bjnath. Would you be able to open a PR to fix the README? |
Wasn't able to push the PR:
|
That's because the standard workflow is for you to "fork" this repo (button at right top of the page). You then push your changes to a new branch in your own fork, and from there you can send a PR. The process is described at https://numpy.org/devdocs/dev/index.html#development-process-summary (just change the name of the repo from |
The rationale for that is that is we let every contributor create new branches in this repo, it would get very messy very quickly. Pretty much every open source project uses this "send PR from forks" method. |
and the step that failed was right out of https://numpy.org/devdocs/dev/index.html#development-process-summary: |
OK, I see -- I have origin set the same as upstream:
I'll fix it and try again. |
Instructs user to install the extended version of Hugo; points to the Hugo install page and the release page; shows the error message you'll get from the standard version.
All set, filed PR #241 |
PS, @rgommers, thanks for clarifying how it works. I was following the steps but couldn't visualize what was happening. |
DOC: Fix Hugo install instructions in README (issue #231)
No worries, thanks for the PR! One more tip: if you add in your commit message next time |
Great tip, will do! Thanks. |
A user who installs Hugo by following the Getting Started link in the README will get the failure
when they run
hugo server
.Users need to install the extended version, e.g.,
which I don't think is mentioned in the page we're linking to.
Extended Hugo is a requirement of the Hugo Fresh theme (see
Troubleshooting
at the bottom the page).The text was updated successfully, but these errors were encountered: