This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Added Warning and Exception annotations #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2020 16:13
See https://github.com/numpy/numpy-stubs/issues/54. Added annotations and tests for: * np.warnings * np.ModuleDeprecationWarning * np.VisibleDeprecationWarning * np.ComplexWarning * np.RankWarning * np.TooHardError * np.AxisError
person142
reviewed
Apr 18, 2020
* Removed ``warnings`` (#57 (comment)) * Deleted a now redundant comment (#57 (comment)) * Created and/or moved a number of tests to fail/ and reveal/ (#57 (comment) and #57 (comment)) * Formatted the main __init__.pyi file with black (#57 (review))
|
Thanks for feedback! I've addressed your points in the latest push. |
|
Great, thanks @BvB93. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #54.
Added annotations and tests for:
np.warningsnp.ModuleDeprecationWarningnp.VisibleDeprecationWarningnp.ComplexWarningnp.RankWarningnp.TooHardErrornp.AxisError