Skip to content

chore: do not test on EOL Node.js versions #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 16 additions & 23 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,19 @@ on:
branches: [ main ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
with:
# Need commit history test for cli-tests
fetch-depth: 0
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run build --if-present
- run: npm run test-ci
env:
CI: true
- run: bash <(curl -s https://codecov.io/bash)
test:
name: Test on Node.js
uses: pkgjs/action/.github/workflows/node-test.yaml@v0
with:
# We need to fetch some specific commits that we are using in our tests. We also need `--deepen=2` for CodCov.
post-checkout-steps: |
- run: git fetch --deepen=2 origin 2b98d02b52a0abe98054eccb351e1e5c71c81bb0 69435db261650dfc74ede6dca89acbe97ba30081
shell: bash
post-install-steps: |
- run: npm run build --if-present
shell: bash
test-command: npm run test-ci
post-test-steps: |
- name: Upload coverage report to Codecov
run: bash <(curl -s https://codecov.io/bash)
shell: bash
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"bin": {
"core-validate-commit": "./bin/cmd.js"
},
"engines": {
"node": "^18.18.0 || >=20.10.0"
},
"author": "Evan Lucas <[email protected]>",
"repository": {
"type": "git",
Expand Down