Skip to content

CP/DP Split: Collect telemetry for cp dp split #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Apr 30, 2025

Collect telemetry for number of data plane pods, control plane pods, and nginx proxy resources attached to a gateway.

Problem: With the control data plane split, there are a few telemetry metrics which need to be updated or added.

Solution: Update/Add telemetry metrics.

Testing: Manually tested these scenarios:

NginxPodCount:

  • Single gateway/nginx pod
  • Replica of single gateway
  • Separate instances of nginx

ControlPlanePodCount:

  • Single NGF/Control plane pod
  • Replica of single NGF/Control plane pod

GatewayAttachedNpCount:

  • None are attached (does not count the one attached to the gatewayclass)
  • Np is attached to a gateway

Closes #3118

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@bjee19 bjee19 requested a review from a team as a code owner April 30, 2025 21:39
@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (6337c97) to head (9cfeda8).
Report is 268 commits behind head on change/control-data-plane-split.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3352      +/-   ##
===================================================================
- Coverage                            89.74%   86.69%   -3.06%     
===================================================================
  Files                                  109      129      +20     
  Lines                                11150    14855    +3705     
  Branches                                50       62      +12     
===================================================================
+ Hits                                 10007    12879    +2872     
- Misses                                1083     1829     +746     
- Partials                                60      147      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 force-pushed the enh/collect-cp-dp-split-telemetry branch from 15ccd00 to 4376f41 Compare April 30, 2025 22:09
@bjee19
Copy link
Contributor Author

bjee19 commented May 1, 2025

Verified changes on AIDF side.

@bjee19 bjee19 merged commit a818c8e into change/control-data-plane-split May 1, 2025
37 checks passed
@bjee19 bjee19 deleted the enh/collect-cp-dp-split-telemetry branch May 1, 2025 23:07
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 1, 2025
sjberman pushed a commit that referenced this pull request May 6, 2025
Collect telemetry for number of data plane pods, control plane pods, and nginx proxy resources attached to a gateway.

Problem: With the control data plane split, there are a few telemetry metrics which need to be updated or added.

Solution: Update/Add telemetry metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants