Skip to content

CP/DP Split: provision NGINX Plus #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sjberman
Copy link
Collaborator

Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace.

Added unit tests.

Testing: Manually deployed using NGINX Plus. All secrets were created and managed properly.

Closes #2844

@sjberman sjberman requested a review from a team as a code owner February 19, 2025 23:10
@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels Feb 19, 2025
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace.

Added unit tests.
@sjberman sjberman requested a review from bjee19 February 21, 2025 14:54
@sjberman sjberman force-pushed the chore/provision-nginx-plus branch from f9faeca to ff1989e Compare February 21, 2025 14:54
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjberman sjberman merged commit 3cbd175 into nginx:change/control-data-plane-split Feb 25, 2025
24 of 25 checks passed
@sjberman sjberman deleted the chore/provision-nginx-plus branch February 25, 2025 01:10
sjberman added a commit that referenced this pull request Feb 25, 2025
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace.

Added unit tests.
sjberman added a commit that referenced this pull request Mar 4, 2025
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace.

Added unit tests.
sjberman added a commit that referenced this pull request Apr 23, 2025
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace.

Added unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks helm-chart Relates to helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants