CP/DP split: Support nginx debug mode when provisioning Data Plane

charts/nginx-gateway-fabric/README.md

@@ -258,10 +258,9 @@ The following table lists the configurable parameters of the NGINX Gateway Fabri
 
 | Key | Description | Type | Default |
 |-----|-------------|------|---------|
-| `nginx` | The nginx section contains the configuration for all NGINX data plane deployments installed by the NGINX Gateway Fabric control plane. | object | `{"config":{},"container":{},"debug":false,"image":{"pullPolicy":"Always","repository":"ghcr.io/nginx/nginx-gateway-fabric/nginx","tag":"edge"},"imagePullSecret":"","imagePullSecrets":[],"kind":"deployment","plus":false,"pod":{},"replicas":1,"service":{"externalTrafficPolicy":"Local","type":"LoadBalancer"},"usage":{"caSecretName":"","clientSSLSecretName":"","endpoint":"","resolver":"","secretName":"nplus-license","skipVerify":false}}` |
+| `nginx` | The nginx section contains the configuration for all NGINX data plane deployments installed by the NGINX Gateway Fabric control plane. | object | `{"config":{},"container":{},"image":{"pullPolicy":"Always","repository":"ghcr.io/nginx/nginx-gateway-fabric/nginx","tag":"edge"},"imagePullSecret":"","imagePullSecrets":[],"kind":"deployment","plus":false,"pod":{},"replicas":1,"service":{"externalTrafficPolicy":"Local","type":"LoadBalancer"},"usage":{"caSecretName":"","clientSSLSecretName":"","endpoint":"","resolver":"","secretName":"nplus-license","skipVerify":false}}` |
 | `nginx.config` | The configuration for the data plane that is contained in the NginxProxy resource. | object | `{}` |
 | `nginx.container` | The container configuration for the NGINX container. | object | `{}` |
-| `nginx.debug` | Enable debugging for NGINX. Uses the nginx-debug binary. The NGINX error log level should be set to debug in the NginxProxy resource. | bool | `false` |
 | `nginx.image.repository` | The NGINX image to use. | string | `"ghcr.io/nginx/nginx-gateway-fabric/nginx"` |
 | `nginx.imagePullSecret` | The name of the secret containing docker registry credentials. Secret must exist in the same namespace as the helm release. The control plane will copy this secret into any namespace where NGINX is deployed. | string | `""` |
 | `nginx.imagePullSecrets` | A list of secret names containing docker registry credentials. Secrets must exist in the same namespace as the helm release. The control plane will copy these secrets into any namespace where NGINX is deployed. | list | `[]` |

charts/nginx-gateway-fabric/templates/nginxproxy.yaml

@@ -23,7 +23,9 @@ spec:
         {{- end }}
         image:
           {{- toYaml .Values.nginx.image | nindent 10 }}
+        {{- if .Values.nginx.debug }}
         debug: {{ .Values.nginx.debug }}
+        {{- end }}
     {{- end }}
     {{- if .Values.nginx.service }}
     service:

charts/nginx-gateway-fabric/values.schema.json

@@ -229,13 +229,6 @@
           "title": "container",
           "type": "object"
         },
-        "debug": {
-          "default": false,
-          "description": "Enable debugging for NGINX. Uses the nginx-debug binary. The NGINX error log level should be set to debug in the NginxProxy resource.",
-          "required": [],
-          "title": "debug",
-          "type": "boolean"
-        },
         "image": {
           "properties": {
             "pullPolicy": {

charts/nginx-gateway-fabric/values.yaml

@@ -425,4 +425,4 @@ nginx:
     # loadBalancerSourceRanges: []
 
   # -- Enable debugging for NGINX. Uses the nginx-debug binary. The NGINX error log level should be set to debug in the NginxProxy resource.
-  debug: false
+  # debug: false

deploy/aws-nlb/deploy.yaml

@@ -301,7 +301,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx

deploy/azure/deploy.yaml

@@ -303,7 +303,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx

deploy/default/deploy.yaml

@@ -301,7 +301,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx

deploy/experimental-nginx-plus/deploy.yaml

@@ -308,7 +308,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: private-registry.nginx.com/nginx-gateway-fabric/nginx-plus

deploy/experimental/deploy.yaml

@@ -306,7 +306,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx

deploy/nginx-plus/deploy.yaml

@@ -303,7 +303,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: private-registry.nginx.com/nginx-gateway-fabric/nginx-plus

deploy/nodeport/deploy.yaml

@@ -301,7 +301,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx

deploy/openshift/deploy.yaml

@@ -311,7 +311,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx

deploy/snippets-filters-nginx-plus/deploy.yaml

@@ -306,7 +306,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: private-registry.nginx.com/nginx-gateway-fabric/nginx-plus

deploy/snippets-filters/deploy.yaml

@@ -304,7 +304,6 @@ spec:
   kubernetes:
     deployment:
       container:
-        debug: false
         image:
           pullPolicy: Always
           repository: ghcr.io/nginx/nginx-gateway-fabric/nginx