Fix revert commit for leader election #3136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3136 +/- ##
====================================================================
- Coverage 89.74% 79.57% -10.18%
====================================================================
Files 109 124 +15
Lines 11150 13470 +2320
Branches 50 62 +12
====================================================================
+ Hits 10007 10719 +712
- Misses 1083 2679 +1596
- Partials 60 72 +12 ☔ View full report in Codecov by Sentry. |
bjee19
approved these changes
Feb 14, 2025
|
One thing to note is in the nginx provisioner, once NGF becomes leader it does not provision nginx if there was an existing gateway. @sjberman by reverting the leader election code there may be a little bit of refactoring of the NginxProvisioner. |
sjberman
reviewed
Feb 15, 2025
|
@bjee19 I'll keep this in mind with my current work |
sjberman
approved these changes
Feb 18, 2025
salonichf5
merged commit 85c6f78
into
change/control-data-plane-split
24 of 37 checks passed
sjberman
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Add back runnables change and call to nginx provisioner enable --------- Co-authored-by: Benjamin Jee <[email protected]>
sjberman
pushed a commit
that referenced
this pull request
Mar 4, 2025
* Add back runnables change and call to nginx provisioner enable --------- Co-authored-by: Benjamin Jee <[email protected]>
sjberman
pushed a commit
that referenced
this pull request
Apr 23, 2025
* Add back runnables change and call to nginx provisioner enable --------- Co-authored-by: Benjamin Jee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix revert commit for leader election story