Skip to content

Add new "Get started" document #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Oct 18, 2024

Proposed changes

This pull request adds a new "Get started" document for NGINX Gateway Fabric. It re-orders the top level page so that it is second after "Overview" as a means to get a reader started as quickly as possible, and is a combination of the existing kind guide, a Helm installation path and the cafe-example on GitHub.

As part of this work, the original kind guide has been deleted: the only context lost is regarding port forwarding, which this new document mentions not requiring. The README for the cafe-example could also be stripped down as a result: the step "skipped" regards how to use a different hostname.

Both of these could instead be added to a general network configuration document.

Closes #2350

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

This commit adds a new "Get started" document for NGINX Gateway Fabric.
It re-orders the top level page so that it is second after "Overview" as
a means to get a reader started as quickly as possible, and is a
combination of the existing kind guide, a Helm installation path and the
cafe-example on GitHub.

As part of this work, the original kind guide has been deleted: the only
context lost is regarding port forwarding, which this new document
mentions not requiring. The README for the cafe-example could also be
stripped down as a result: the step "skipped" regards how to use a
different hostname.

Both of these could instead be added to a general network configuration
document.
@ADubhlaoich ADubhlaoich self-assigned this Oct 18, 2024
@ADubhlaoich ADubhlaoich requested review from a team as code owners October 18, 2024 14:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2024
@ADubhlaoich
Copy link
Contributor Author

pre-commit.ci autofix

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (0d8b9a0) to head (bd05994).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2700   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         110      110           
  Lines       10913    10913           
  Branches       50       50           
=======================================
  Hits         9755     9755           
  Misses       1100     1100           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich
Copy link
Contributor Author

Incorporated feedback into the PR. Much of it was carelessness on my part to get the PR up for visibility: my apologies.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking on this work!

@ADubhlaoich
Copy link
Contributor Author

@conradwt As the person who filed the original issue, any thoughts?

@ADubhlaoich ADubhlaoich requested a review from sjberman October 22, 2024 12:32
@ADubhlaoich
Copy link
Contributor Author

pre-commit.ci autofix

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) October 22, 2024 14:36
@ADubhlaoich ADubhlaoich merged commit 8cd9d52 into nginx:main Oct 22, 2024
40 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/get-started branch October 22, 2024 14:47
ADubhlaoich added a commit to ADubhlaoich/ngf-doc-work that referenced this pull request Oct 22, 2024
This commit adds a new "Get started" document for NGINX Gateway Fabric.
It re-orders the top level page so that it is second after "Overview" as
a means to get a reader started as quickly as possible, and is a
combination of the existing kind guide, a Helm installation path and the
cafe-example on GitHub.

As part of this work, the original kind guide has been deleted: the only
context lost is regarding port forwarding, which this new document
mentions not requiring. The README for the cafe-example could also be
stripped down as a result: the step "skipped" regards how to use a
different hostname.

Both of these could instead be added to a general network configuration
document.

Co-authored-by: Saylor Berman <[email protected]>
ADubhlaoich added a commit to ADubhlaoich/ngf-doc-work that referenced this pull request Oct 22, 2024
This commit adds a new "Get started" document for NGINX Gateway Fabric.
It re-orders the top level page so that it is second after "Overview" as
a means to get a reader started as quickly as possible, and is a
combination of the existing kind guide, a Helm installation path and the
cafe-example on GitHub.

As part of this work, the original kind guide has been deleted: the only
context lost is regarding port forwarding, which this new document
mentions not requiring. The README for the cafe-example could also be
stripped down as a result: the step "skipped" regards how to use a
different hostname.

Both of these could instead be added to a general network configuration
document.

Co-authored-by: Saylor Berman <[email protected]>
ADubhlaoich added a commit that referenced this pull request Oct 22, 2024
Add new "Get started" document (#2700)

This commit adds a new "Get started" document for NGINX Gateway Fabric.
It re-orders the top level page so that it is second after "Overview" as
a means to get a reader started as quickly as possible, and is a
combination of the existing kind guide, a Helm installation path and the
cafe-example on GitHub.

As part of this work, the original kind guide has been deleted: the only
context lost is regarding port forwarding, which this new document
mentions not requiring. The README for the cafe-example could also be
stripped down as a result: the step "skipped" regards how to use a
different hostname.

Both of these could instead be added to a general network configuration
document.

Co-authored-by: Saylor Berman <[email protected]>
@conradwt
Copy link

@ADubhlaoich I believe that I found it by using steps in the 'Getting Started' on this repo. Let me go through it and I'll report back to you.

miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
This commit adds a new "Get started" document for NGINX Gateway Fabric.
It re-orders the top level page so that it is second after "Overview" as
a means to get a reader started as quickly as possible, and is a
combination of the existing kind guide, a Helm installation path and the
cafe-example on GitHub.

As part of this work, the original kind guide has been deleted: the only
context lost is regarding port forwarding, which this new document
mentions not requiring. The README for the cafe-example could also be
stripped down as a result: the step "skipped" regards how to use a
different hostname.

Both of these could instead be added to a general network configuration
document.

Co-authored-by: Saylor Berman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

NGINX Gateway Fabric Docs Not Very Easy To Follow
4 participants