[UPSTREAM-SYNC] Add the LLMResponse struct to hold response information #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
shaneutt
requested changes
May 7, 2025
| Body string | ||
|
|
||
| // IsStreaming indicates whether or not the response is being streamed by the model | ||
| IsSreaming bool |
There was a problem hiding this comment.
Suggested change
| IsSreaming bool | |
| IsStreaming bool |
|
Recreating this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a LLMResponse struct to hold select information from the response. A reference to an instance of this struct has been added to the SchedulingContext struct.
The SchedulingContext struct is used in both request and response plugin handling.
During request handling the LLMRequest field will have a value and the LLMResponse field will be nill.
During response handling the LLMRequest field will be nil and the LLMResponse field will have a value.
This is a step to better PostResponse plugin support.