Skip to content

Add P/D scheduler #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 5, 2025
Merged

Add P/D scheduler #115

merged 20 commits into from
May 5, 2025

Conversation

mayabar
Copy link
Collaborator

@mayabar mayabar commented May 4, 2025

Ref #114
*Still working on tests

mayabar added 4 commits May 4, 2025 16:45
…or decode. P/D scheduler is enabled by environment variable value, list of scorers and their weight are defined by environment variables

+ delete pd-filter
* dev:
  Added a simple unit test for the PostResponse plugin invocation
  Invoke the PostResponse handlers and send any added headers to the user
  Added code to scheduler to enable running the PostResponse plugins
  Use an init() function instead of modifying the scheduler code to inject our config
  Added PostResponse to scheduler config
  Fixed scorer tests
@mayabar mayabar requested review from elevran, shmuelk and vMaroon May 4, 2025 14:22
Copy link
Collaborator

@shmuelk shmuelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR with Maya and after the changes she made it LGTM

@mayabar mayabar merged commit 9f01f6c into neuralmagic:dev May 5, 2025
1 check passed
clubanderson pushed a commit that referenced this pull request May 7, 2025
* Add P/D scheduler - use 2 schedulers in it, one for prefill and one for decode. P/D scheduler is enabled by environment variable value, list of scorers and their weight are defined by environment variables
+ delete pd-filter

* Remove unused variable

* Update readme file with envirnment variables relevant to P/D scheduler

* Fix problem caused by merge

* Add documentation for PDScheduler.Schedule function

* Update names of prefill and decode filters to avoid spaces

* Update comment for prefill/decode fitlers

* Change IsPDEnabled to PDEnabled

* Fix typo in readme

* Fix pd scheduler behavior for short promprts

* Fix prefill/decode related text in  readme

* Remove redundant filter creation of prefil/decode filters + make promptLengthThreshold local
Add function for schedulerContext creation

* Fixes in readme

* fix compilation prblem

* add pd scheduler test

* add postResponse plugins array to prefile and decode config

* fix comment in test

* fix pd-scheduler test
clubanderson pushed a commit that referenced this pull request May 7, 2025
* Add P/D scheduler - use 2 schedulers in it, one for prefill and one for decode. P/D scheduler is enabled by environment variable value, list of scorers and their weight are defined by environment variables
+ delete pd-filter

* Remove unused variable

* Update readme file with envirnment variables relevant to P/D scheduler

* Fix problem caused by merge

* Add documentation for PDScheduler.Schedule function

* Update names of prefill and decode filters to avoid spaces

* Update comment for prefill/decode fitlers

* Change IsPDEnabled to PDEnabled

* Fix typo in readme

* Fix pd scheduler behavior for short promprts

* Fix prefill/decode related text in  readme

* Remove redundant filter creation of prefil/decode filters + make promptLengthThreshold local
Add function for schedulerContext creation

* Fixes in readme

* fix compilation prblem

* add pd scheduler test

* add postResponse plugins array to prefile and decode config

* fix comment in test

* fix pd-scheduler test
clubanderson pushed a commit that referenced this pull request May 7, 2025
* Add P/D scheduler - use 2 schedulers in it, one for prefill and one for decode. P/D scheduler is enabled by environment variable value, list of scorers and their weight are defined by environment variables
+ delete pd-filter

* Remove unused variable

* Update readme file with envirnment variables relevant to P/D scheduler

* Fix problem caused by merge

* Add documentation for PDScheduler.Schedule function

* Update names of prefill and decode filters to avoid spaces

* Update comment for prefill/decode fitlers

* Change IsPDEnabled to PDEnabled

* Fix typo in readme

* Fix pd scheduler behavior for short promprts

* Fix prefill/decode related text in  readme

* Remove redundant filter creation of prefil/decode filters + make promptLengthThreshold local
Add function for schedulerContext creation

* Fixes in readme

* fix compilation prblem

* add pd scheduler test

* add postResponse plugins array to prefile and decode config

* fix comment in test

* fix pd-scheduler test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants