[build]: Updating vllm deployment to support the latest images and scorers. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kfir Toledo <[email protected]>
elevran
approved these changes
May 4, 2025
| key: ${HF_SECRET_KEY} | ||
| - name: ENABLE_KVCACHE_AWARE_SCORER |
There was a problem hiding this comment.
we'll need to find a more elegant way of loading/enabling specific plugins (more than just filters and/or scorers) - but ok for now.
|
Please assess if the CICD failure is related to the code added. |
|
@elevran, it is not related to my code. The same failure occurred in the last commit that was merged: |
clubanderson
pushed a commit
that referenced
this pull request
May 7, 2025
Update the vLLM P2P deployment to support KV-cache and load scorers. Signed-off-by: Kfir Toledo <[email protected]>
clubanderson
pushed a commit
that referenced
this pull request
May 7, 2025
Update the vLLM P2P deployment to support KV-cache and load scorers. Signed-off-by: Kfir Toledo <[email protected]>
clubanderson
pushed a commit
that referenced
this pull request
May 7, 2025
Update the vLLM P2P deployment to support KV-cache and load scorers. Signed-off-by: Kfir Toledo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the vLLM P2P deployment to support KV-cache and load scorers.