This repository was archived by the owner on May 10, 2021. It is now read-only.
Update to prevent #55 from occurring again #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change in the readme is to help future developers not have binary issues across lambda functions created by the next build command.
|
Fixes #55 |
|
I would be very wary of setting this as the default option without reviewing this more. I realize that it fixes #55, but it means that all dependent node_modules for each page are included in the bundle, slowing down the build and increasing the function zips bundled for lambda significantly. In my case this simple change increased each of my page zip sizes 7x. |
@spencewood that's a good point. I updated this to mention it's only needed to copy over binaries. |
|
thanks for opening this @garrypolley! we hear @spencewood's point and will keep it in mind :). |
lindsaylevine
added a commit
that referenced
this pull request
Oct 23, 2020
- README rebrand - Fix: update logs to correct path constants in prepareFolders ([#58](#58)) - Fix: show experimental-serverless-trace target option in README ([#59](#59)) - Fix: x-forwarded-host is undefined on Netlify ([#54](#54)) - Fix: No-op redirect for root catch-all page chunks ([#52](#52)) - prettier pre-commit hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in the readme is to help future developers not have binary issues across lambda functions created by the next build command.