Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

feat: enhance README #155

Merged
merged 1 commit into from
Jan 24, 2021
Merged

feat: enhance README #155

merged 1 commit into from
Jan 24, 2021

Conversation

ctjlewis
Copy link
Contributor

This draft makes small accessibility changes regarding heading hierarchical headings, and adds a foonote about private submodules.

@ctjlewis ctjlewis changed the title Enhance README feat: enhance README Jan 21, 2021
@lindsaylevine lindsaylevine added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 21, 2021
@lindsaylevine
Copy link
Contributor

#154

```bash
# git remote set-url [remote] [url]
git remote set-url origin [email protected]:owner/project.git
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per your comment on the issue about this being "out-of-the-box" on vercel.. is this supported on vercel? only a few months ago this was commented: https://github.com/vercel/vercel/discussions/4566#discussioncomment-125253

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting - all I know is that this project deployed to Vercel w/o issue.

Wonder if they didn't adjust the default permissions for the GH access key so that it would have access to private repos by default, can't think otherwise how it didn't fail.

@ctjlewis ctjlewis marked this pull request as ready for review January 22, 2021 11:39
Copy link
Contributor

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!!! as somewhat discussed on the issue, this will help me remember to include this in any new netlify documentation for next.js :) thanks so much!!

@lindsaylevine lindsaylevine merged commit 7bf10cd into netlify:main Jan 24, 2021
lindsaylevine added a commit that referenced this pull request Jan 26, 2021
- Put back next/image support ([#158](#158))
- Fix: strip file extension when checking if route is dynamic ([#155](#155))
- Fix: prevent copy of .public to .public ([#146](#146))
- Fix: add check if pages-manifest exists before reading ([#147](#147))
- Fix: throw error if .next/static cannot be found ([#148](#148))
- Fix: remove unnecessary * from headers rule ([#152](#152))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants