Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

remove unneccessary * from headers rule that broke ntl dev #152

Merged
merged 1 commit into from
Jan 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cypress/plugins/deployProject.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ const getBaseUrl = require("./getBaseUrl");
const deployLocally = ({ project }, config) => {
process.stdout.write(`Deploying project: ${project}...`);

// _headers breaks netlify dev
removeSync(join(config.buildsFolder, project, "out_publish", "_headers"));

// Start server. Must start in detached mode, so that we can kill it later.
// Otherwise, we seem unable to kill it.
// See: https://medium.com/@almenon214/killing-processes-with-node-772ffdd19aad
Expand Down
2 changes: 1 addition & 1 deletion lib/steps/setupHeaders.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const setupHeaders = (publishPath) => {
// Add rule to override cache control for static chunks
const indentNewLine = (s) => `\n ${s}`;
const staticChunkRule = [
`/*/_next/static/chunks/*`,
`/_next/static/chunks/*`,
indentNewLine(`cache-control: public`),
indentNewLine(`cache-control: max-age=31536000`),
indentNewLine(`cache-control: immutable`),
Expand Down
2 changes: 1 addition & 1 deletion tests/__snapshots__/defaults.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`Headers creates Netlify headers 1`] = `
"# Next-on-Netlify Headers
/*/_next/static/chunks/*
/_next/static/chunks/*
cache-control: public
cache-control: max-age=31536000
cache-control: immutable"
Expand Down