This repository was archived by the owner on May 10, 2021. It is now read-only.
Fix cypress:local: Skip test for cache control header #118
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache control header in netlify dev does not include "public" for static assets. This is unlike netlify.app. We should probably set headers in a _headers file as suggested by: #110 For now, we simply skip the test when running the Cypress tests locally.
lindsaylevine
approved these changes
Dec 15, 2020
| }); | ||
| if (Cypress.env("DEPLOY") !== "local") { | ||
| cy.request("/subfolder/static").then((response) => { | ||
| expect(response.headers["cache-control"]).to.include("public"); |
There was a problem hiding this comment.
lowercase cache-control? 🤔
There was a problem hiding this comment.
Should it be uppercase? 😅 We have it lowercase in default_spec.js, too, and it seems to be working:
There was a problem hiding this comment.
Apparently, headers are supposed to be case-insensitive: cypress-io/cypress#2879 (comment)
Cypress transforms all headers to lowercase, so that devs don't have to worry about it: cypress-io/cypress#2879 (comment)
There was a problem hiding this comment.
dope!! merge away!!!!!!
lindsaylevine
added
bug
type: bug
lindsaylevine
added a commit
that referenced
this pull request
Jan 3, 2021
- Support for i18n in Next 10 ([#75](#75)) - dependabot: node-notifier from 8.0.0 to 8.0.1 ([#125](#125)) - Expose Netlify function params as netlifyFunctionParams ([#119](#119)) - Fix: local cypress cache control ([#118](#118)) - Fix: add res.finished to createResponseObject ([#117](#117)) - Fix: Windows support ([#101](#101)) - Improve logs for specified functions/publish dirs ([#100](#100))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a failing test when running
npm run cypress:local.The failing test is testing the cache control header of a pre-rendered, static page and expecting the headers to include "public". This is the case on netlify.app. However, in netlify dev this cache control header is not present, causing the test to fail.
For now, we simply skip the test when running the Cypress tests locally (as we do in
default_spec.js). In the long term, we should probably set headers in a_headersfile as suggested by #110.