-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
I forked this branch to use for my current site which has catchall routes and I can attest to it seeming to work well. Seems like this would be good to add! Once it's merged in I'll be able to remove my fork :) thanks for this |
Please mind a silly question @spencewood : I'm having issues with Thanks! |
I believe the issue with netlify and |
Hi @spencewood and @alxhghs, this is great! 🙌 Thank for you opening this pull request. Sorry for taking so long to get back. Somehow this totally slipped my attention. I'm on it now and will hopefully merge the changes today. 🚀 I'll keep you posted. PS: @Yagogc, thanks for pointing out the issue with |
Update next-on-netlify to the version proposed in PR #1: netlify/next-on-netlify#1 This adds support for NextJS catch-all routes.
Oh no, I was adding some commits to this PR and messed up a forced push. 😬 It automatically closed this PR and I can't reopen this one. I've repushed the commits to a new PR (#5). Sincere apologies about that... 😭 |
Happy to say that the latest release of Thank you @spencewood and @alxhghs for your excellent contributions (and sorry again for messing up this PR... 🙈) |
Hey @Yagogc, I know it's been a while, but I'm happy to report that Here's the full list of changes for Let me know if you have any questions or run into any issues! Happy hacking 🔥 |
This simply pulls in the latest code from https://github.com/danielcondemarin/serverless-next.js/blob/master/packages/serverless-nextjs-component/lib/expressifyDynamicRoute.js which supports dynamic catch all routes.