This repository was archived by the owner on Sep 12, 2019. It is now read-only.
Make ports for local server dynamic #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful. |
|
@jschatz1 should I merge this? |
swyxio
suggested changes
Jul 8, 2019
src/commands/dev/index.js
Outdated
| dist | ||
| }; | ||
| } | ||
|
|
||
| // Reset port if not manually specified, to make it dynamic | ||
| if (!(config.dev && config.dev.port)) { |
There was a problem hiding this comment.
Good catch, thank you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Allow the user to run more than one dev server at one time.
- Test plan
netlify devin your project directorynetlify devin a different project directory- Description for the changelog
For the static server, we have moved from the absolute
proxyPort: 3999togetPortmethod that chooses an available port.For the
8888server port, we use dynamic port fromgetPortif the user hasn't specifiedportin theirconfig.- A picture of a cute animal (not mandatory but encouraged)
