chore: Remove lodash #130
Merged
chore: Remove lodash #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahetter
added
the
type: chore
nickytonline
suggested changes
May 18, 2022
There was a problem hiding this comment.
This is looking great @sarahetter! I l left some comments and change requests.
|
Depends on #132 to be merged first |
ericapisani
approved these changes
May 19, 2022
nickytonline
approved these changes
May 19, 2022
There was a problem hiding this comment.
Looks good, @sarahetter! There are so many anys in the codebase that the changes in this PR are fine. As discussed. we'll schedule cleaning up types in here at some point.
Also, as we discovered, _.flow was using any pretty liberally. 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes (most) of the lodash we have in this repo. I kept
mergeWithas there wasn't any simple ES6/quick fix I could write up to replace this function, so I opted to only include thelodash.mergewithpackage, instead of all of lodash.Closes: #129