feat: Add support for advanced redirect types #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahetter
requested review from
ascorbic,
nickytonline,
orinokai and
ericapisani
github-actions
bot
added
the
type: feature
ascorbic
approved these changes
Apr 20, 2022
|
Ah maybe blog post isn't the right term - just a post in their Support's "How to Guide". I couldn't find any similar examples in their official docs. |
|
Oh yeah. Looks like that's their cloud support guide, because it's not in the main OSS product |
jaska120
reviewed
May 12, 2022
Comment on lines
-20
to
-21
| `Language`, | ||
| `Country`, |
There was a problem hiding this comment.
This was a breaking change and it should have been introduced in a major bump. All the redirects were possible previously, but the change broke our delpoyment. I do agree that the conditions key may be more suitable, but let's just be cautious with the breaking changes in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for advanced redirect types in gatsby, as mentioned in their support blog post
I've also added a snapshot test to ensure that each of these types of redirects are being output to the _redirects file properly.
Closes: #93