Refactor boltstub, always run related tests #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously driver allowed boltkit to be an optional dependency and relied on neokit (submodule) to start/stop neo4j database. That's why all tests that use stub server from boltkit were executed as a separate step. These days boltkit is always required and neokit is gone. This commit refactors stub server handling and turns all boltkit tests into normal tests that run as part of `npm test` and `runTests` script. These tests are however skipped in browser testing because it is not possible to spawn child processes when in phantomjs environment.
ali-ince
reviewed
Sep 27, 2017
|
|
||
| it('should run query', done => { | ||
| if (!boltkit.BoltKitSupport) { | ||
| if (!boltStub.supported) { |
There was a problem hiding this comment.
What do you think about switching between describe or xdescribe based on the value of boltStub.supported before L24? Something like
const fdescribe = boltStub.supported ? describe : xdesribe;
fdescribe('direct driver with stub server', () => ....There was a problem hiding this comment.
Interesting point, if will save us from all these boltStub.supported checks. Let's maybe do it in a separate PR. I'll create a card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously driver allowed boltkit to be an optional dependency and relied on neokit (submodule) to start/stop neo4j database. That's why all tests that use stub server from boltkit were executed as a separate step. These days boltkit is always required and neokit is gone.
This commit refactors stub server handling and turns all boltkit tests into normal tests that run as part of
npm testandrunTestsscript. These tests are however skipped in browser testing because it is not possible to spawn child processes when in phantomjs environment.