Do not retry transaction when it is terminated #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.2-no-retry-when-terminated
branch
7 times, most recently
from
5f68f71 to
111ab2b
Compare
This commit makes transaction functions `Session.readTransaction()` and `Session#writeTransaction()` not retry when executed transaction was explicitly terminated by the user. Such termination can happen when `Session#close()` is called or `killQuery` procedure is used. Transaction termination can result in two different status codes on the server, both classified as transient errors which is not entirely correct. So we need additional status code checks in the retying code.
lutovich
force-pushed
the
1.2-no-retry-when-terminated
branch
from
111ab2b to
c31eab6
Compare
lutovich
force-pushed
the
1.2-no-retry-when-terminated
branch
from
6d66592 to
28a4e95
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes transaction functions
Session.readTransaction()andSession#writeTransaction()not retry when executed transaction was explicitly terminated by the user. Such termination can happen whenSession#close()is called orkillQueryprocedure is used.Transaction termination can result in two different status codes on the server, both classified as transient errors which is not entirely correct. So we need additional status code checks in the retying code.