Skip to content

Migrate Testkit backend to Netty implementation #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

injectives
Copy link
Contributor

No description provided.

@injectives injectives marked this pull request as draft August 23, 2021 13:36
@injectives injectives force-pushed the feature/syncmigration branch from bf0b4dc to 6f74b72 Compare August 23, 2021 14:10
@injectives injectives marked this pull request as ready for review August 23, 2021 14:10
@injectives injectives force-pushed the feature/syncmigration branch from 6f74b72 to 59c9c7e Compare August 23, 2021 14:16
@injectives injectives changed the title Migration Testkit backend to Netty implementation Migrate Testkit backend to Netty implementation Aug 23, 2021
This brings both sync and asynchronous paths in TestKitState in symmetry.
In addition, I noticed that the transaction related tests behaved differently in sync and async (when a tx is not found). I fixed that.
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to add / change from my side. I hope I didn't add to many bugs :)

@injectives injectives merged commit 4238f82 into neo4j:4.4 Aug 24, 2021
@injectives injectives deleted the feature/syncmigration branch August 24, 2021 13:08
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Sep 6, 2021
* Migrate Testkit backend to Netty implementation

* Remove unnessary Optional in processAsync.

This brings both sync and asynchronous paths in TestKitState in symmetry.
In addition, I noticed that the transaction related tests behaved differently in sync and async (when a tx is not found). I fixed that.

* Remove redundant lines

Co-authored-by: Michael Simons <[email protected]>
injectives added a commit that referenced this pull request Sep 6, 2021
* Add support for Resolver and DomainNameResolver to async Testkit backend (#992)

* Decouple TestkitState from CommandProcessor. (#993)

This commit remoces the command processor from the TestKit state. The processor is supposed to use that state, not to be part of it.
However, some requests, like `NewDriver` need the processor to trigger further state.
Therefor the processor is now provided as injectable value via Jackson, so that any request can indicate that it needs a processor via a constructor argument.

* Remove unnessary Lombok noise. (#995)

* Migrate Testkit backend to Netty implementation (#994)

* Migrate Testkit backend to Netty implementation

* Remove unnessary Optional in processAsync.

This brings both sync and asynchronous paths in TestKitState in symmetry.
In addition, I noticed that the transaction related tests behaved differently in sync and async (when a tx is not found). I fixed that.

* Remove redundant lines

Co-authored-by: Michael Simons <[email protected]>

* Add reactive backend support (#998)

This update brings reactive backend support.

Its scope is limited to providing partial transparent support for existing test cases. More updates are expected in future PRs.

Co-authored-by: Michael Simons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants