Skip to content

Migrate tests from Java Driver to Testkit #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

Migrate tests from Java Driver to Testkit #978

merged 1 commit into from
Aug 11, 2021

Conversation

injectives
Copy link
Contributor

Migrated tests:

  • shouldAllowPullAll -> test_should_pull_all_when_fetch_is_minus_one_using_driver_configuration (Bolt bump from v4 to v4.1)
  • shouldThrowCommitErrorWhenTransactionCommit -> test_should_error_on_commit_failure_using_tx_commit
  • shouldServerWithBoltV4SupportMultiDb -> test_should_check_multi_db_support
  • shouldServerWithBoltV3NotSupportMultiDb -> test_should_check_multi_db_support
  • shouldBeAbleHandleNOOPsDuringRunCypher -> test_should_accept_noop_during_records_streaming
  • shouldThrowCorrectErrorOnCommitFailure -> test_should_error_on_database_shutdown_using_tx_commit
  • shouldThrowCorrectErrorOnRunFailure -> test_should_error_on_database_shutdown_using_tx_run

@injectives
Migrate tests from Java Driver to Testkit
2b5ca73 
Migrated tests:
- shouldAllowPullAll -> test_should_pull_all_when_fetch_is_minus_one_using_driver_configuration (Bolt bump from v4 to v4.1)
- shouldThrowCommitErrorWhenTransactionCommit -> test_should_error_on_commit_failure_using_tx_commit
- shouldServerWithBoltV4SupportMultiDb -> test_should_check_multi_db_support
- shouldServerWithBoltV3NotSupportMultiDb -> test_should_check_multi_db_support
- shouldBeAbleHandleNOOPsDuringRunCypher -> test_should_accept_noop_during_records_streaming
- shouldThrowCorrectErrorOnCommitFailure -> test_should_error_on_database_shutdown_using_tx_commit
- shouldThrowCorrectErrorOnRunFailure -> test_should_error_on_database_shutdown_using_tx_run
@injectives injectives requested a review from gjmwoods August 11, 2021 15:35
gjmwoods
gjmwoods approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@gjmwoods gjmwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@injectives injectives merged commit 41180bb into neo4j:4.4 Aug 11, 2021
@injectives injectives deleted the feature/migration branch August 11, 2021 17:51
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Aug 12, 2021
@injectives
Migrate tests from Java Driver to Testkit (neo4j#978)
0763b5f 
Migrated tests:
- shouldAllowPullAll -> test_should_pull_all_when_fetch_is_minus_one_using_driver_configuration (Bolt bump from v4 to v4.1)
- shouldThrowCommitErrorWhenTransactionCommit -> test_should_error_on_commit_failure_using_tx_commit
- shouldServerWithBoltV4SupportMultiDb -> test_should_check_multi_db_support
- shouldServerWithBoltV3NotSupportMultiDb -> test_should_check_multi_db_support
- shouldBeAbleHandleNOOPsDuringRunCypher -> test_should_accept_noop_during_records_streaming
- shouldThrowCorrectErrorOnCommitFailure -> test_should_error_on_database_shutdown_using_tx_commit
- shouldThrowCorrectErrorOnRunFailure -> test_should_error_on_database_shutdown_using_tx_run
@injectives injectives mentioned this pull request Aug 12, 2021
Merged
injectives added a commit that referenced this pull request Aug 12, 2021
@injectives
Migrate tests from Java Driver to Testkit (#978) (#980)
79c215f 
Migrated tests:
- shouldAllowPullAll -> test_should_pull_all_when_fetch_is_minus_one_using_driver_configuration (Bolt bump from v4 to v4.1)
- shouldThrowCommitErrorWhenTransactionCommit -> test_should_error_on_commit_failure_using_tx_commit
- shouldServerWithBoltV4SupportMultiDb -> test_should_check_multi_db_support
- shouldServerWithBoltV3NotSupportMultiDb -> test_should_check_multi_db_support
- shouldBeAbleHandleNOOPsDuringRunCypher -> test_should_accept_noop_during_records_streaming
- shouldThrowCorrectErrorOnCommitFailure -> test_should_error_on_database_shutdown_using_tx_commit
- shouldThrowCorrectErrorOnRunFailure -> test_should_error_on_database_shutdown_using_tx_run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjmwoods gjmwoods gjmwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injectives @gjmwoods