Skip to content

Migrate tests to Testkit #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

Migrate tests to Testkit #977

merged 1 commit into from
Aug 11, 2021

Conversation

injectives
Copy link
Contributor

Cherry-pick: #976.

This updated also includes:

  • TransactionClose request support (Temporary:TransactionClose feature)
  • Driver fetch size configuration (Temporary:DriverFetchSize feature)

Migrated tests:

  • shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback
  • shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close
  • shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close
  • shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1)
  • shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1)

@injectives
Migrate tests to Testkit (neo4j#976)
d1b6b3c 
This updated also includes:
- TransactionClose request support (`Temporary:TransactionClose` feature)
- Driver fetch size configuration (`Temporary:DriverFetchSize` feature)

Migrated tests:
- shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback
- shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close
- shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close
- shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1)
- shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1)
@injectives injectives requested a review from gjmwoods August 11, 2021 13:11
@injectives injectives merged commit 24d459c into neo4j:4.3 Aug 11, 2021
@injectives injectives deleted the feature/cherry-pick branch August 11, 2021 13:20
@injectives injectives mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjmwoods gjmwoods gjmwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injectives @gjmwoods