New results api, take 2 #97
Conversation
o Replace Field, Property by Entry o Fuse MapAccessor and PropertyMapAccessor into MapAccessor o Made RecordAccessor a separate interface o Remove some unneeded methods o Replace propertyCount, fieldCount with size
o Also ensure inner iterator is set to null as soon as possible to free resources early
o This is the dual of skip - and was IMHO missing
boggle
force-pushed
the
new-results-api
branch
from
7cd30ec to
5bf0e5e
Compare
| * @param <V> the Java type of the contained value | ||
| */ | ||
| @Immutable | ||
| public interface Property<V> | ||
| public interface Entry<V> |
There was a problem hiding this comment.
Doesn't the name clash with java.util.Map.Entry make it cumbersome to use?
There was a problem hiding this comment.
Maybe.. I usually don't import it and just use Map.Entry directly in my Java code; that was the thinking here but I realize now that is not a good thing to assume by default. What would be a good generic alternative? We could just have a type Pair<K, V>? Wdyt?
There was a problem hiding this comment.
Wikipedia agrees with that idea: https://en.wikipedia.org/wiki/Associative_array
There was a problem hiding this comment.
I almost always import Entry but I am not sure if I am representative either. Pair, is fine by me.
|
Something is weird with the PR build, it looks like there is a hanging db server. Let's see if this clears up tomorrow. |
| import org.junit.Test; | ||
|
|
||
| public class TypePlayTest | ||
| { |
There was a problem hiding this comment.
? What's the purpose of this test?
|
licenses... |
boggle
force-pushed
the
new-results-api
branch
from
25300e8 to
269f4d8
Compare
boggle
force-pushed
the
new-results-api
branch
from
269f4d8 to
a51f810
Compare
No description provided.