New results api #96
Merged
New results api #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boggle
force-pushed
the
new-results-api
branch
6 times, most recently
from
7b57b25 to
be5a91b
Compare
Includes: Incorporate feedback from PR discussion around API refactoring o Also adds a bunch of new asFooArray extraction methods o Drop support for value( byte[] ) o Removed lenient extraction (asBoolean(), asString() in favour of being explicit) o char[] arrays are now treated as Strings o Add containsKey() and entries() to MapLike
…sKey() (former containsKey())
…alues.value( Object o )
o New *Accessor naming o ListAccessor, MapAccessor no longer imply CollectionAccessor o RecordAccessor no longer inherits CollectionAccessor (use keys().size() if you need that) o Result.position and skip now return longs o Add Record.asMapValue o Rename Map.Entry to Field o Add Map.field* methods for better naming on records o Introduce PropertyAccessor and Field o Better distinction between maps of unordered properties and records of ordered fields o Also fixes some places where we still failed to return Values.NULL o Removes CollectionAccessor
o Added bounds checking for `asInt`, `asByte`, ...
o We should fan out to versions inside internal; not outside of it
o Rename {Standard|Simple} -> Internal
o Also break inheritance between Field and Property in favour of adding asProperty (this inheritance failed to work property with equals)
jakewins
force-pushed
the
new-results-api
branch
from
be5a91b to
e1d696e
Compare
|
Merging this, with a plan to review some aspects of it further in follow up PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.