Skip to content

Remove Resource.close() method override with misleading javadoc #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

injectives
Copy link
Contributor

No description provided.

@injectives injectives requested review from gjmwoods and michael-simons and removed request for gjmwoods June 15, 2021 15:16
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. And please delete lines 24 to 26 (Javadoc comment)

@injectives
Copy link
Contributor Author

Agree. And please delete lines 24 to 26 (Javadoc comment)

Good catch, thank you 👍 Updated.

@injectives injectives merged commit 2971fe6 into neo4j:4.3 Jun 16, 2021
@injectives injectives deleted the feature/resource branch June 16, 2021 08:47
@gjmwoods gjmwoods requested review from gjmwoods and removed request for gjmwoods June 16, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants