Skip to content

Add support for BackendError to backend responses #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import neo4j.org.testkit.backend.messages.TestkitModule;
import neo4j.org.testkit.backend.messages.requests.TestkitRequest;
import neo4j.org.testkit.backend.messages.responses.BackendError;
import neo4j.org.testkit.backend.messages.responses.DriverError;
import neo4j.org.testkit.backend.messages.responses.TestkitErrorResponse;
import neo4j.org.testkit.backend.messages.responses.TestkitResponse;

import java.io.BufferedReader;
Expand Down Expand Up @@ -154,7 +154,7 @@ else if ( currentLine.equals( "#request end" ) )
// Unknown error, interpret this as a backend error.
// Report to frontend and rethrow, note that if socket been
// closed the writing will throw itself...
writeResponse( TestkitErrorResponse.builder().errorMessage( e.toString() ).build() );
writeResponse( BackendError.builder().data( BackendError.BackendErrorBody.builder().msg( e.toString() ).build() ).build() );
// This won't print if there was an IO exception since line above will rethrow
e.printStackTrace();
throw e;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
import lombok.RequiredArgsConstructor;
import lombok.Setter;
import neo4j.org.testkit.backend.TestkitState;
import neo4j.org.testkit.backend.messages.responses.BackendError;
import neo4j.org.testkit.backend.messages.responses.DomainNameResolutionRequired;
import neo4j.org.testkit.backend.messages.responses.Driver;
import neo4j.org.testkit.backend.messages.responses.DriverError;
import neo4j.org.testkit.backend.messages.responses.ResolverResolutionRequired;
import neo4j.org.testkit.backend.messages.responses.TestkitErrorResponse;
import neo4j.org.testkit.backend.messages.responses.TestkitResponse;

import java.net.URI;
Expand Down Expand Up @@ -67,8 +67,13 @@ public TestkitResponse process( TestkitState testkitState )
data.authorizationToken.getTokens().get( "realm" ) );
break;
default:
return TestkitErrorResponse.builder().errorMessage( "Auth scheme " + data.authorizationToken.getTokens().get( "scheme" ) + "not implemented" )
.build();
return BackendError.builder()
.data( BackendError
.BackendErrorBody.builder()
.msg( "Auth scheme " + data.authorizationToken.getTokens().get( "scheme" ) +
"not implemented" )
.build() )
.build();
}

Config.ConfigBuilder configBuilder = Config.builder();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,21 @@
@Setter
@Getter
@Builder
public class TestkitBackendErrorResponse implements TestkitResponse
public class BackendError implements TestkitResponse
{
private final BackendErrorBody data;

@Override
public String testkitName()
{
return "BackendError";
}

@Setter
@Getter
@Builder
public static class BackendErrorBody
{
private String msg;
}
}

This file was deleted.