Remove circular references in exceptions during the commit #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
4.3-fix-semantic-error-endless-recursion
branch
from
a97d6ec to
7bc3b5e
Compare
The error issue happened because the cursor failure is already the cause of the commit or rollback failure. This generates a circular reference when both of the exceptions are combined. This situation can create stack overflow when the exception is logged in some logging libraries. The solution don't add the cursor exception as the cause of the exception, this way it will not be wrongly combined creating a circular reference.
bigmontz
force-pushed
the
4.3-fix-semantic-error-endless-recursion
branch
from
7bc3b5e to
7cb0359
Compare
bigmontz
changed the title
injectives
reviewed
May 25, 2021
driver/src/test/java/org/neo4j/driver/integration/async/AsyncQueryIT.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error issue happened because the cursor failure is already the cause of the commit or rollback failure. This generates a circular reference when both of the exceptions are combined.
This situation can create stack overflow when the exception is logged in some logging libraries.
The solution don't add the cursor exception as the cause of the exception, this way it will not be wrongly combined creating a circular reference.