Skip to content

Implement backend driver feature list #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

Implement backend driver feature list #889

merged 1 commit into from
May 11, 2021

Conversation

injectives
Copy link
Contributor

@injectives injectives commented May 4, 2021 •
edited
Loading

Implement backend driver feature list

Testkit: neo4j-drivers/testkit#104

@injectives injectives self-assigned this May 4, 2021
@injectives injectives force-pushed the feature/backend-driver-features branch 3 times, most recently from a0d8737 to 7c37e51 Compare May 4, 2021 19:42
@injectives injectives marked this pull request as draft May 4, 2021 19:42
@injectives injectives mentioned this pull request May 4, 2021
Merged
@injectives injectives force-pushed the feature/backend-driver-features branch from 7c37e51 to 7f7fb96 Compare May 5, 2021 12:44
@injectives injectives marked this pull request as ready for review May 5, 2021 14:42
@injectives injectives requested a review from gjmwoods May 5, 2021 14:51
@bigmontz
Copy link
Contributor

@injectives, please remove the skip I've added on the teskit project after this PR be merged. I've skipped the GetFeature request for the Java driver because it was causing tests get failure in certain scenarios.

@injectives
Copy link
Contributor Author

@injectives, please remove the skip I've added on the teskit project after this PR be merged. I've skipped the GetFeature request for the Java driver because it was causing tests get failure in certain scenarios.

Thanks. This has been done in the following PR: https://github.com/neo4j-drivers/testkit/pull/115/files#diff-f198c28ccad625341295209ff816768c59a4a386908961d17961dbbd23c24aa1L73

@bigmontz bigmontz mentioned this pull request May 11, 2021
Closed
@injectives
Copy link
Contributor Author

injectives commented May 11, 2021 •
edited
Loading

@gjmwoods, as discussed this PR will be merged now. The 4.3 builds fail because of the problem with latest server build, which is being looked at. The 3 tests failed in Testkit because there is no consumption of result. The following PR fixes it: neo4j-drivers/testkit#117

@injectives injectives merged commit add3ade into neo4j:4.3 May 11, 2021
gjmwoods pushed a commit to gjmwoods/neo4j-java-driver that referenced this pull request May 26, 2021
@injectives @gjmwoods
Implement backend driver feature list (neo4j#889)
d519fb5
gjmwoods added a commit that referenced this pull request May 27, 2021
@gjmwoods @injectives @bigmontz
4.2 teskit cherry pick (#900)
e7ad6c7 
* Transaction Rollback (#887)

* Implement backend driver feature list (#889)

* testkit-backend: fix TestkitListDeserializer (#893)

Enabling `list of maps` deserialization by adding a special case for treating this data type.

The extras `nextToken` calls were removed because this was making the deserializer leaves the parent object, this way breaking the `map of lists` deserialization.

Co-authored-by: Dmitriy Tverdiakov <[email protected]>
Co-authored-by: Antonio Barcélos <[email protected]>
@injectives injectives deleted the feature/backend-driver-features branch June 24, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjmwoods gjmwoods gjmwoods approved these changes

Assignees

@injectives injectives

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@injectives @bigmontz @gjmwoods