Ensure error is propagated from rx queries correctly. #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjmwoods
approved these changes
Feb 24, 2020
zhenlineo
force-pushed
the
4.0-fix-rx-stress-it
branch
from
e818e55 to
e1bf71c
Compare
added 2 commits
April 8, 2020 17:24
The rx queries should be semantically the same as the async queries. Fixed a few wrong handling of finish future and error propergation used in rx queries.
However this bookmark is not used for querying nodes count. It is only used to randomly generate queries waiting or not waiting for bookmark.
zhenlineo
force-pushed
the
4.0-fix-rx-stress-it
branch
from
e1bf71c to
0c4062d
Compare
zhenlineo
force-pushed
the
4.0-fix-rx-stress-it
branch
from
0c4062d to
e054ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rx queries should be semantically the same as the async queries.
Fixed a few wrong handling of finish future and error propergation used in rx queries.