Helpful error message when nesting transactions in the same session #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
4.0-nested-queries-with-reactive-session
branch
from
598671e to
466be5d
Compare
added 3 commits
October 30, 2019 18:14
…ion. Session only support one active transaction (either auto-commit or exmplicit transaction) at a given time. For async and blocking sessions, when we chaining a new transaction while there is an on-going auto-commit transaction, we can allow users to "nesting transactions" in one session by sending a pull all for the preceding auto-commit transaction. However we cannot do the same for reactive sessions as project reactive will error if the underlying publisher does not respect back pressure. Ensure helpful error message when accessing results after the statement runner where the results belongs to is closed.
zhenlineo
force-pushed
the
4.0-nested-queries-with-reactive-session
branch
from
2c9c835 to
1110bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give helpful error message when nesting transactions in the same session.
Give helpful error message when accessing records on a result which has already been consumed with
Result#consumeorStatementRunner#close.Updated some reactive example code to ensure the close is always closed.