Prevent NPE in SessionConfig#equals. #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
force-pushed
the
fix_sessionconfig_equals
branch
from
005a747 to
412097e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
SessionConfig.builder()disallows the user to input the literal value ofnullas database name, the name is by default null and when not configured else,SessionConfighas literalnullas value for the database.Under this conditions, the
equalsmethod is broken and will throw an NPE in any case where the receiver of equals has no database name configured, i.e.:SessionConfig.builder().build().equals( SessionConfig.builder().build())This PR fixes the behaviour and adds tests.