Added database name in the ResultSummary. #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
2.0-database-name-in-summary
branch
from
5818f3d to
bae2507
Compare
ali-ince
approved these changes
May 3, 2019
driver/src/main/java/org/neo4j/driver/internal/util/MetadataExtractor.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 6, 2019 13:37
The database name default to `null` if the server does not support multi-databases when the database name is returned in result summary. However `null` is a forbidden value for database in session parameters. Then for user who want to connect to default db but do not want ot omit invoke `withDatabase` method on session parameter, they have to use empty string to work aroud our API design. This PR allows `null` as a valid database name for session parameters, while disallows empty string as it is an invalid database name to users.
zhenlineo
force-pushed
the
2.0-database-name-in-summary
branch
from
35ebb4e to
80203b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the server to stream
dbwith database name in the result summary.