Handle nanosecond normalization in IsoDuration #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, test code that generated random durations could create a duration with negative amount of nanoseconds. Such duration is now normalized by the database so that nanoseconds value is always in range from 0 to 999_999_999. This commit makes tests only create random durations with nanoseconds in that range. Otherwise some test assertions fail because they expect non-normalized value to be returned back.
lutovich
force-pushed
the
1.6-ns-normalization
branch
from
defe4b5 to
1bda475
Compare
Database normalizes nanoseconds to be in range from 0 to 999_999_999. `IsoDuration` previously did no calculations in it's `#toString()` and returned incorrect result. This commit makes it return correct string representation despite normalized second and nanosecond components. It will also do normalization in the constructor using `java.time.Duration#ofSeconds(long, long)` in order to return correct strings for durations created on the client side and not returned from the database.
lutovich
force-pushed
the
1.6-ns-normalization
branch
from
1bda475 to
edc09ce
Compare
sherfert
reviewed
May 7, 2018
|
@sherfert server also does other conversions like 12 months -> year, etc. We do not want this it drivers for now. So this is a minimal fix for seconds & nanoseconds handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.