Add Value#asXXX(defalutValue) for primary types

[zhenlineo]

Add Value#computeOrDefault(Function<Value, T> mapper, T defaultValue) for other types
Add Value#computeOrNull(Function<Value, T> mapper) for shortcuts to call Value#computeOrDefault(Function<Value, T> mapper, T defaultValue=null)

[lutovich]

@zhenlineo Changes look good to me. Made couple minor comments. Methods with default value should also be added for native temporal types from java.time:

• LocalDate asLocalDate(LocalDate defaultValue)
• OffsetTime asOffsetTime(OffsetTime defaultValue)
• LocalTime asLocalTime(LocalTime defaultValue)
• LocalDateTime asLocalDateTime(LocalDateTime defaultValue)
• ZonedDateTime asZonedDateTime(ZonedDateTime defaultValue)

[lutovich]

Maybe add description and @throws Uncoercible if value types are incompatible.

[zhenlineo]

It was in the javadoc.

[lutovich]

Maybe add description and @throws Uncoercible if value types are incompatible.

[zhenlineo]

Done

[lutovich]

Empty line should probably be removed

[lutovich]

Empty line should probably be removed

[zhenlineo]

@sarmbruster Given we have general methods
Values#computeOrDefault(Function<Value, T> mapper, T defaultValue) and Value#computeOrNull(Function<Value, T> mapper)
for all types to use,

On which level do you suggest to have asXXX(defaultVal) methods?

1. primary types + String only,
2. all Java Native types
3. all types that are not Node, Path and Rel
4. other

[sarmbruster]

Hi @zhenlineo,
what's the difference between primary and native types? (1 and 2)
I basically want defaults to be supported for all property values. So String, primitive types, spatial and temporal types, and arrays

[zhenlineo]

@sarmbruster I mean primitive types.

So basically I guess you are asking for the following API:

asString(String def);

// primitives 
asBoolean(boolean def);
asInt(int def);
asLong(long def);
asFloat(float def);
asDouble(double def);

asNumber(Number def);

// array, list, map
asByteArray(byte[] def);
asList(List def);
asMap(Map def);

asObject(Object def);

// node, rel, path
asEntityOrNull();
asNodeOrNull();
asRelationshipOrNull();
asPathOrNull();

// asEntity(Entity entity)   ===> Node + Rel = Entity, Node, Rel, and Path cannot be created so only default to null
// asNode(Node node)
// asRelationship(Relationship rel)
// asPath(Path path)

// spatial, temporal
asPoint(Point def);
asLocalDate(LocalDate d);
asOffsetTime(OffsetTime t);
asLocalTime(LocalTime t);
asLocalDateTime(LocalDateTime d);
asZonedDateTime(ZonedDateTime d);
asIsoDuration(IsoDuration d);

But how about I give you a smaller API:

asString(String def);

// primitives
asBoolean(boolean def);
asInt(int def);
asLong(long def);
asFloat(float def);
asDouble(double def);

computeOrDefault(Function<Value, T> mapper, T defaultValue)
computeOrNull(Function<Value, T> mapper)

// The following are equivalent:
// Point point = pointValue.asPoint(myDefaultPoint) 
// Point point = pointValue.computeOrDefault(Value::asPoint, myDefaultPoint)

// We also have an extra helper method:
// Point pointOrNull = pointValue.computeOrNull(Value::asPoint);

Which API is more useful to you (most of users)? or how would you improve one of them?

[lutovich]

Imho a slightly trimmed version 1 would be great:

asString(String def);

// primitives
asBoolean(boolean def);
asInt(int def);
asLong(long def);
asFloat(float def);
asDouble(double def);

// array, list, map
asByteArray(byte[] def);
asList(List def);
asMap(Map def);

// spatial, temporal
asPoint(Point def);
asLocalDate(LocalDate def);
asOffsetTime(OffsetTime def);
asLocalTime(LocalTime def);
asLocalDateTime(LocalDateTime def);
asZonedDateTime(ZonedDateTime def);
asIsoDuration(IsoDuration def);

[sarmbruster]

+1 on @lutovich 's previous commit. I guess we should have a asString(String def) as well - it seems to be missing in the list.
These asXXXX plus asString would IMHO cover >90% of all uses.

For the remainder having a type agnostic computeOrDefault is a good idea. computeOrNull is IMHO not needed since it's just as computeOrDefault, mapper, null).