Replaced Point2D and Point3D with Point #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format with type was never used, all values have always been formatted "by value". This commit just forces all `Value` implementations to have `#toString()`.
Driver is now able to send and receive instances of Date type. They are represented as `java.time.LocalDate` objects.
It is useless because current driver version is a pre-release version.
Driver is now able to send and receive instances of Time type. They are represented as `java.time.OffsetTime` objects.
Driver is now able to send and receive instances of LocalTime type. They are represented as `java.time.LocalTime` objects.
Driver is now able to send and receive instances of LocalDateTime type. They are represented as `java.time.LocalDateTime` objects.
Driver is now able to send and receive instances of DateTime type. They are represented as `java.time.ZonedDateTime` objects. `ZonedDateTime` instances contain time zone information either as numeric offset or as a zone id/name.
Driver is now able to send and receive instances of Duration type. They are represented as instances of custom `org.neo4j.driver.v1.types.Duration` interface. It's needed because Cypher's duration contains months, days, seconds and nanoseconds. There exists no default class in `java.time` package to represent a combination of these temporal values.
Removed "_TyCon" suffix, made code use `#toString()` instead of `#typeName()`.
Instead of direct constructor invocation. So creation of value implementations and internal classes only live in `Values` helper class and is not duplicated.
By extracting generic test methods.
To assert that driver can send and receive DateTime with time zone information as offset and zone name.
By using method references and lambdas instead of static final function implementations.
So it does not clash with `java.time.Duration` and specifies that it's a combination of date-based amount and time-based amount.
Driver represents duration as a custom `IsoDuration` interface. It's a combination of date-based amount and time-based amount. This commit makes driver accept `java.time.Period` and `java.time.Duration` as parameters and convert them to `IsoDuration`.
zhenlineo
changed the title
ali-ince
approved these changes
Mar 15, 2018
| * <p> | ||
| * Value that represents a 3D point can be created using {@link Values#point3D(long, double, double, double)} method. | ||
| * Value that represents a point can be created using {@link Values#point(int, double, double)} method. |
There was a problem hiding this comment.
Shall we also add a reference to the Values#point(int, double, double, double) overload?
| private final double x; | ||
| private final double y; | ||
| private final double z; | ||
|
|
||
| public InternalPoint3D( long srid, double x, double y, double z ) | ||
| public InternalPoint3D( int srid, double x, double y ) |
There was a problem hiding this comment.
Do we need this constructor since we already have a distinct InternalPoint2D?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #474