Improve default config values for connection pool #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit changes default values from "unlimited" to lower and more
realistic values. Modified settings are:
* `maxConnectionLifetime` - changed from unlimited to 1 hour because it seems
reasonable to periodically "refresh" connections and make sure they are
not affected by network infrastructure.
* `maxConnectionPoolSize` - changed from `Integer.MAX_VALUE` to 100 because
unlimited connection pool is dangerous and might result in excessive use
of resources and OOMs in the database, if connections there are
not limited.
* `connectionAcquisitionTimeout` - changed from unlimited to 60 seconds
to not cause infinite blocking.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changes default values from "unlimited" to lower and more realistic values. Modified settings are:
maxConnectionLifetime- changed from unlimited to 1 hour because it seemsreasonable to periodically "refresh" connections and make sure they are
not affected by network infrastructure.
maxConnectionPoolSize- changed fromInteger.MAX_VALUEto 100 becauseunlimited connection pool is dangerous and might result in excessive use
of resources and OOMs in the database, if connections there are
not limited.
connectionAcquisitionTimeout- changed from unlimited to 60 secondsto not cause infinite blocking.