Improve Session#reset() & cleanup of Connection#release() #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LG |
lutovich
force-pushed
the
1.5-session-reset-release-resources
branch
2 times, most recently
from
0328dbc to
0cd953a
Compare
Previously it tried to first release connection and then mark existing transaction as terminated. This could've been problematic because it allowed transaction to be used on the client after RESET, which clears connection state on the server. This commit makes `Session#reset()` first mark existing transaction as terminated and only then release the connection. Releasing connection implies RESET.
Replaced `Connection#releaseInBackground()` and `Connection#releaseNow()` with single `Connection#release()`. Two old methods only differed in return type. New method returns a `CompletionStage` which can either be ignored or chained, if needed.
lutovich
force-pushed
the
1.5-session-reset-release-resources
branch
from
0cd953a to
5a174eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #426