Propagate not consumed failures when closing session and transaction #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aligns behaviour of `Session#close()` and `Session#closeAsync()` so that later one also waits for the latest result to be fully fetched. It makes possible to consume result after session is closed and allows propagation of query errors in `#closeAsync()`. Errors are propagated only if they were not consumed by reading the result cursor.
Made transaction state enum responsible for knowing if transaction is open or closed. This seems prettier than large boolean expression.
This commit makes transactions surface unconsumed query errors when doing commit or rollback. It's achieved by keeping track of all result cursors and polling them for unconsumed failures when doing commit or rollback.
Calls `StatementResult#summary()` and `StatementResultCursor#summaryAsync()` should propagate unconsumed query errors. They are in this sense same as `#consume()` and `#consumeAsync()` respectively. Previously summary calls simply ignored existing unconsumed failure. This commit makes them propagate it instead. Note that it's later still possible to access summary after failure is consumed.
When closing sessions and committing/rolling back transactions. Previously only last async cursor failure was propagated. This means successfully completed cursors could hide not consumed failures from previous queries. This commit makes session and transaction track all results and query them for not consumed errors when session is closed or transaction either committed or rolled back.
Replaced anonymous classes with lambdas, made some tests use existing driver instead of creating a new one.
lutovich
force-pushed
the
1.5-consume-failures-when-tx-close
branch
from
448a0cd to
cc6e520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.