More helper methods in StatementResultCursor #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which returns future of a record if result contains a single record. Otherwise it returns a failed future. This method is convenient and safe shortcut for consuming a single-record result.
`StatementResultCursor#forEachAsync()` will now return future of `ResultSummary` instead of future of void. This simplifies the API a bit an makes it more convenient to use summary after forEach is completed.
New method allows application of a transformation function to each record. Returned list will contain transformed values. This allows writing a bit more concise code when records need to be converted to some other objects. Returned future will be failed if given function ever throws. Also improved error handling in `#forEachAsync(Consumer<Record>)`.
Which allows skip/drop all incoming records and returns future of `ResultSummary`.
Otherwise TCK tests fail.
zhenlineo
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following methods to
StatementResultCursor:CompletionStage<Record> singleAsync()to safely retrieve single record from the cursor and assert that cursor contains exactly one recordCompletionStage<List<T>> listAsync(Function<Record, T>)to transform all incoming records and store them in listCompletionStage<ResultSummary> consumeAsync()to drop/skip all incoming records and get result summaryThey are added for convenience and to be consistent with existing blocking API in
StatementResult.Also
#forEachAsync(Consumer<Record>)now returns future ofResultSummary.