Skip to content

Improve logging around connection establishment #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

lutovich
Copy link
Contributor

It will help diagnose long running TLS handshakes.

Example log:

2017-09-26 06:58:47,115 [Connection] [1206883981] Connecting to localhost:7687, secure: true
2017-09-26 06:58:47,117 [Connection] [1206883981] Running TLS handshake
2017-09-26 06:58:47,139 [Connection] [1206883981] TLS handshake completed
2017-09-26 06:58:47,139 [Connection] [1206883981] Connected to localhost:7687, secure: true
2017-09-26 06:58:47,139 [Connection] [1206883981] Negotiating protocol with localhost:7687
2017-09-26 06:58:47,139 [Connection] [1206883981] C: [HANDSHAKE] 0x6060B017
2017-09-26 06:58:47,140 [Connection] [1206883981] C: [HANDSHAKE] [1, 0, 0, 0]
2017-09-26 06:58:47,141 [Connection] [1206883981] S: [HANDSHAKE] -> 1
2017-09-26 06:58:47,142 [Connection] [1206883981] Selected protocol class org.neo4j.driver.internal.net.SocketProtocolV1 with localhost:7687

which gives us timestamps for various connection establishment stages.

It will help diagnose long running TLS handshakes.
@zhenlineo zhenlineo merged commit 0c60f63 into neo4j:1.4 Sep 27, 2017
@lutovich lutovich deleted the 1.4-tls-logging branch September 27, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants