Java 8, CompletionStage in async and stress test improvements #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.5-completable-future
branch
17 times, most recently
from
87c56d9 to
59d735f
Compare
lutovich
force-pushed
the
1.5-completable-future
branch
2 times, most recently
from
7849bbb to
dcf946f
Compare
Commit changes source and target java version to 1.8 and makes all public async APIs use `CompletionStage` instead of `Response`, which is now removed. This allows easier future chaining and makes API much more usable. Currently all internal futures are converted to `CompletionStage` at the highest level before returning to the user.
Split `CausalClusteringStressIT` into two separate tests - one for single instance and one for CC. Added testing of async API. Extracted all infra classes to top level.
This commit makes driver use `CompletableFuture` instead of netty-based `InternalFuture` and `InternalPromise`.
Both blocking and async commands added to execute wrong query "RETURN" and query failing at runtime "UNWIND [10, 5, 0] AS x RETURN 10 / x". Queries are executed both through session and transaction. These commands are useful to verify that all resources (like netty channel) are correctly released on errors.
lutovich
force-pushed
the
1.5-completable-future
branch
from
dcf946f to
93a29b7
Compare
ali-ince
reviewed
Sep 27, 2017
| } | ||
| else | ||
| { | ||
| queueRecord( record ); | ||
| } | ||
| } | ||
|
|
||
| public synchronized InternalFuture<Record> nextAsync() | ||
| public synchronized CompletionStage<Record> nextAsync() |
There was a problem hiding this comment.
I think we can improve concurrent performance among #onRecord() and #nextAsync() methods by avoiding method level synchronized access. We will have to keep an eye on recordFuture and queuing records (we can maybe use ConcurrentLinkedQueue instead of Queue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps required java version to 8 so that we can use
CompletionStageandCompletableFuturein async API.Stress test has been split into a CC and single instance test. It now also tests async API.