Support IPv6 in routing procedure responses #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves parsing in `BoltServerAddress` to support IPv6 in `getServers()` and `getRoutingTable()` procedure responses.
martinfurmanski
approved these changes
Jul 19, 2017
| } | ||
|
|
||
| @Test | ||
| public void shouldParseIPv6Addresses() |
There was a problem hiding this comment.
Could you try also with zone-id like [fe80::b279:2f%en0]:1234 ?
| @@ -63,7 +63,7 @@ public void shouldReceiveServerInfoAfterInit() throws Throwable | |||
| SocketClient socket = mock( SocketClient.class ); | |||
| SocketConnection conn = new SocketConnection( socket, SERVER_INFO, DEV_NULL_LOGGER ); | |||
|
|
|||
| when( socket.address() ).thenReturn( BoltServerAddress.from( URI.create( "http://neo4j.com:9000" ) ) ); | |||
| when( socket.address() ).thenReturn( new BoltServerAddress( URI.create( "http://neo4j.com:9000" ) ) ); | |||
There was a problem hiding this comment.
Unrelated, but why is this http:// ?
|
In the server code I handle the hostname string representation as only ::1 and not as [::1]. Only when combined in some form are the brackets used, e.g. bolt://[::1]:1234 or in config [fe80::1]:1234 etc. Just for consideration. |
To support IPv6 with and without brackets and zone ids.
|
@martinfurmanski comments should now be addressed |
ali-ince
approved these changes
Jul 20, 2017
|
@martinfurmanski, @ali-ince thanks for the review! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves parsing in
BoltServerAddressto support IPv6 ingetServers()andgetRoutingTable()procedure responses.