Skip to content

char values should be encoded as strings #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2017

Conversation

ali-ince
Copy link
Contributor

Added overloads of pack and value methods with a char parameter to stop calls of this to be invoked on int overloads. Added corresponding tests.

…op calls of this to be invoked on int overloads. Added corresponding tests.
Copy link
Contributor

@lutovich lutovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Maybe we could also add Values#value(char... input)?

@lutovich lutovich merged commit 89c842f into neo4j:1.4 Jun 21, 2017
@ali-ince ali-ince deleted the 1.4-char-should-encoded-as-string branch June 29, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants