-
Notifications
You must be signed in to change notification settings - Fork 155
Update routing according to specification #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
...java/org/neo4j/driver/internal/cluster/GetServersProcedureClusterCompositionProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.neo4j.driver.internal.cluster; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.neo4j.driver.internal.spi.Connection; | ||
| import org.neo4j.driver.internal.util.Clock; | ||
| import org.neo4j.driver.v1.Logger; | ||
| import org.neo4j.driver.v1.Record; | ||
| import org.neo4j.driver.v1.exceptions.ClientException; | ||
| import org.neo4j.driver.v1.exceptions.ProtocolException; | ||
| import org.neo4j.driver.v1.exceptions.ServiceUnavailableException; | ||
| import org.neo4j.driver.v1.exceptions.value.ValueException; | ||
|
|
||
| import static java.lang.String.format; | ||
|
|
||
| public class GetServersProcedureClusterCompositionProvider implements ClusterCompositionProvider | ||
| { | ||
| private final String GET_SERVERS = "dbms.cluster.routing.getServers"; | ||
| private final String PROTOCOL_ERROR_MESSAGE = "Failed to parse '" + GET_SERVERS + | ||
| "' result received from server due to "; | ||
|
|
||
| private final Clock clock; | ||
| private final Logger log; | ||
| private final GetServersProcedureRunner getServersRunner; | ||
|
|
||
| public GetServersProcedureClusterCompositionProvider( Clock clock, Logger log ) | ||
| { | ||
| this( clock, log, new GetServersProcedureRunner() ); | ||
| } | ||
|
|
||
| GetServersProcedureClusterCompositionProvider( Clock clock, Logger log, GetServersProcedureRunner getServersRunner ) | ||
| { | ||
| this.clock = clock; | ||
| this.log = log; | ||
| this.getServersRunner = getServersRunner; | ||
| } | ||
|
|
||
| @Override | ||
| public ClusterCompositionResponse getClusterComposition( Connection connection ) | ||
| { | ||
| List<Record> records = null; | ||
|
|
||
| // failed to invoke procedure | ||
| try | ||
| { | ||
| records = getServersRunner.run( connection ); | ||
| } | ||
| catch ( ClientException e ) | ||
| { | ||
| return new ClusterCompositionResponse.Failure( new ServiceUnavailableException( format( | ||
| "Failed to call '%s' procedure on server. " + | ||
| "Please make sure that there is a Neo4j 3.1+ causal cluster up running.", GET_SERVERS ), e ) ); | ||
| } | ||
|
|
||
| log.info( "Got getServers response: %s", records ); | ||
| long now = clock.millis(); | ||
|
|
||
| // the record size is wrong | ||
| if ( records.size() != 1 ) | ||
| { | ||
| return new ClusterCompositionResponse.Failure( new ProtocolException( format( | ||
| "%srecords received '%s' is too few or too many.", PROTOCOL_ERROR_MESSAGE, | ||
| records.size() ) ) ); | ||
| } | ||
|
|
||
| // failed to parse the record | ||
| ClusterComposition cluster; | ||
| try | ||
| { | ||
| cluster = ClusterComposition.parse( records.get( 0 ), now ); | ||
| } | ||
| catch ( ValueException e ) | ||
| { | ||
| return new ClusterCompositionResponse.Failure( new ProtocolException( format( | ||
| "%sunparsable record received.", PROTOCOL_ERROR_MESSAGE ), e ) ); | ||
| } | ||
|
|
||
| // the cluster result is not a legal reply | ||
| if ( cluster.hasRoutersAndReaders() ) | ||
| { | ||
| return new ClusterCompositionResponse.Failure( new ProtocolException( format( | ||
| "%sno router or reader found in response.", PROTOCOL_ERROR_MESSAGE ) ) ); | ||
| } | ||
|
|
||
| // all good | ||
| return new ClusterCompositionResponse.Success( cluster ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about
ClusterCompositionProviderImplname for this class?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this long name better, as it allows us to have other providers such as
FileClusterCompositionProviderorGetServers2ProcedureClusterCompositionProvider