Update routing according to specification #314
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.neo4j.driver.internal.cluster; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.neo4j.driver.internal.spi.Connection; | ||
| import org.neo4j.driver.internal.util.Clock; | ||
| import org.neo4j.driver.v1.Logger; | ||
| import org.neo4j.driver.v1.Record; | ||
| import org.neo4j.driver.v1.exceptions.ClientException; | ||
| import org.neo4j.driver.v1.exceptions.ProtocolException; | ||
| import org.neo4j.driver.v1.exceptions.ServiceUnavailableException; | ||
| import org.neo4j.driver.v1.exceptions.value.ValueException; | ||
|
|
||
| import static java.lang.String.format; | ||
|
|
||
| public interface ClusterCompositionProvider | ||
| { | ||
| GetClusterCompositionResponse getClusterComposition( Connection connection ); | ||
|
|
||
| class Default implements ClusterCompositionProvider | ||
|
There was a problem hiding this comment. Let's move this implementation to a separate file, I think it deserves this :) |
||
| { | ||
| private String GET_SERVERS = "dbms.cluster.routing.getServers"; | ||
| private String PROTOCOL_ERROR_MESSAGE = "Failed to parse '" + GET_SERVERS + "' result received from server " + | ||
| "due to "; | ||
|
|
||
| private final Clock clock; | ||
| private final Logger log; | ||
| private final GetServersRunner getServersRunner; | ||
|
|
||
| public Default( Clock clock, Logger log ) | ||
| { | ||
| this( clock, log, new GetServersRunner() ); | ||
| } | ||
|
|
||
| Default( Clock clock, Logger log, GetServersRunner getServersRunner ) | ||
| { | ||
| this.clock = clock; | ||
| this.log = log; | ||
| this.getServersRunner = getServersRunner; | ||
| } | ||
|
|
||
| @Override | ||
| public GetClusterCompositionResponse getClusterComposition( Connection connection ) | ||
| { | ||
| List<Record> records = null; | ||
|
|
||
| // failed to invoke procedure | ||
| try | ||
| { | ||
| records = getServersRunner.run( connection ); | ||
| } | ||
| catch ( ClientException e ) | ||
| { | ||
| return new GetClusterCompositionResponse.Failure( new ServiceUnavailableException( format( | ||
| "Failed to call '%s' procedure on server. " + | ||
| "Please make sure that there is a Neo4j 3.1+ causal cluster up running.", GET_SERVERS ), e ) ); | ||
| } | ||
|
|
||
| log.info( "Got getServers response: %s", records ); | ||
| long now = clock.millis(); | ||
|
|
||
| // the record size is wrong | ||
| if ( records.size() != 1 ) | ||
| { | ||
| return new GetClusterCompositionResponse.Failure( new ProtocolException( format( | ||
| "%srecords received '%s' is too few or too many.", PROTOCOL_ERROR_MESSAGE, | ||
| records.size() ) ) ); | ||
| } | ||
|
|
||
| // failed to parse the record | ||
| ClusterComposition cluster; | ||
| try | ||
| { | ||
| cluster = ClusterComposition.parse( records.get( 0 ), now ); | ||
| } | ||
| catch ( ValueException e ) | ||
| { | ||
| return new GetClusterCompositionResponse.Failure( new ProtocolException( format( | ||
| "%sunparsable record received.", PROTOCOL_ERROR_MESSAGE ), e ) ); | ||
| } | ||
|
|
||
| // the cluster result is not a legal reply | ||
| if ( cluster.isIllegalResponse() ) | ||
| { | ||
| return new GetClusterCompositionResponse.Failure( new ProtocolException( format( | ||
| "%sno router or reader found in response.", PROTOCOL_ERROR_MESSAGE ) ) ); | ||
| } | ||
|
|
||
| // all good | ||
| return new GetClusterCompositionResponse.Success( cluster ); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.neo4j.driver.internal.cluster; | ||
|
|
||
| public interface GetClusterCompositionResponse | ||
| { | ||
| ClusterComposition clusterComposition(); | ||
|
|
||
| class Failure implements GetClusterCompositionResponse | ||
| { | ||
| private final RuntimeException error; | ||
|
|
||
| public Failure( RuntimeException t ) | ||
| { | ||
| this.error = t; | ||
| } | ||
|
|
||
| @Override | ||
| public ClusterComposition clusterComposition() | ||
| { | ||
| throw this.error; | ||
| } | ||
| } | ||
|
|
||
| class Success implements GetClusterCompositionResponse | ||
| { | ||
| private final ClusterComposition cluster; | ||
|
|
||
| public Success( ClusterComposition cluster ) | ||
| { | ||
| this.cluster = cluster; | ||
| } | ||
|
|
||
| @Override | ||
| public ClusterComposition clusterComposition() | ||
| { | ||
| return cluster; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.neo4j.driver.internal.cluster; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.neo4j.driver.internal.NetworkSession; | ||
| import org.neo4j.driver.internal.spi.Connection; | ||
| import org.neo4j.driver.v1.Record; | ||
| import org.neo4j.driver.v1.Statement; | ||
|
|
||
| public class GetServersRunner | ||
| { | ||
| private String CALL_GET_SERVERS = "CALL dbms.cluster.routing.getServers"; | ||
|
|
||
| public List<Record> run( Connection connection ) | ||
| { | ||
| return NetworkSession.run( connection, new Statement( CALL_GET_SERVERS ) ).list(); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can name this method
#hasWriters()to be less ambiguous?