Throw ServiceUnavailableException when socket write fails #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.1-better-exception
branch
from
6069e6e to
f85d046
Compare
|
Could you add test for encrypted connections too? |
Previously `ClientException` was thrown which was incorrect and resulted in connections not being properly disposed.
lutovich
force-pushed
the
1.1-better-exception
branch
from
f85d046 to
b46f48a
Compare
|
@zhenlineo changed test in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ClientExceptionwas thrown which was incorrect and resulted in connections not being properly disposed.Also made small cleanup of unused/test-only methods and classes.